Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equal: Generate presence checks for bytes fields, where necessary #53

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

misberner
Copy link
Contributor

Updates the equal code generation to correctly generate presence checks for bytes fields where necessary, by distinguishing []byte(nil) from []byte{}. See #52 for a more detailed description.

Fixes #52 .

Copy link
Member

@vmg vmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your attention to detail! I don't think we would catch any of these corner cases organically since we don't use Equals in Vitess ourselves. ❤️

@vmg vmg merged commit a059103 into planetscale:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

equal: presence of bytes fields not honored
2 participants