Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added details about generating pool methods to README #88

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

biosvs
Copy link
Contributor

@biosvs biosvs commented Aug 9, 2023

Hi!

It was tricky to find out how to generate pools for messages. I think additional comments in README would help people.

It also closes #33

Signed-off-by: Vitalii Levitskii <vitalii@uber.com>
Copy link
Member

@mattrobenolt mattrobenolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement! 🥇

@mattrobenolt mattrobenolt merged commit 1a874c6 into planetscale:main Aug 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to get pooling methods to gen
2 participants