Issue #204: Fix high CPU utilization after disconnects / connection losses #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebbo94BY
force-pushed
the
Issue-204-Exit-loop-on-disconnect
branch
from
b3d0ec5
to
bb830fd
Compare
Sebbo94BY
force-pushed
the
Issue-204-Exit-loop-on-disconnect
branch
2 times, most recently
from
f476083
to
19e2e7e
Compare
added 2 commits
August 16, 2023 22:08
This change should help to exit stuck loops, when the library is not connected to the remote server anymore. - Fixes the existing `isConnected()` function to properly return TRUE or FALSE - Adds a PHPUnit test for the `isConnected()` function - Adds the connection status as condition to loops in order to abort, when it disconnected
When connected with `blocking=0` (non-blocking mode), the PHP script usually wants to stay connected, so the library shouldn't automatically disconnect it all the time. Instead, the user needs to manually disconnect.
Sebbo94BY
force-pushed
the
Issue-204-Exit-loop-on-disconnect
branch
from
19e2e7e
to
c8e8cfe
Compare
Sebbo94BY
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
blocking=0(non-blocking mode)Before (without this change):
pselect6(13, [12], [], [], {tv_sec=10, tv_nsec=0}, NULL) = 1 (in [12], left {tv_sec=9, tv_nsec=999998860})(see https://linux.die.net/man/2/pselect6)After (with this change):
Closes #204