Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for flask 2.0 #239

Merged
merged 4 commits into from
Jun 11, 2021
Merged

add support for flask 2.0 #239

merged 4 commits into from
Jun 11, 2021

Conversation

dekim24
Copy link
Contributor

@dekim24 dekim24 commented Jun 10, 2021 •
edited
Loading

  • updated flask version requirements to allow flask 2.x
  • from flask import json_available was deprecated in flask 1.x, and removed in flask 2.x. we should no longer need it since we don't support flask 0.x
  • added a few version combinations for automated tests using flask v2.
    • flask 2 was released in May 2021 whereas marshmallow 3 was released in 2019. based on that, I added a few older versions + the 3 most recent marshmallow versions to test alongside flask 2.0.

in progress:

  • install this package locally w/ flask v2 onto some internal repos that use flask-rebar, and see if there are any issues not identified through unit tests.
    • so far, I've tried updating flask-toolbox - a bunch of unit tests broke bc of changes in marshmallow, but no issues related to flask-rebar so far.

@dekim24 dekim24 added the wip A work in progress label Jun 10, 2021
@dekim24 dekim24 requested a review from a team as a code owner June 10, 2021 13:55
@dekim24 dekim24 mentioned this pull request Jun 10, 2021
Closed
@dekim24 dekim24 removed the wip A work in progress label Jun 10, 2021
@dekim24 dekim24 changed the title [WIP] support flask 2.0 add support for flask 2.0 Jun 10, 2021
@dekim24 dekim24 requested a review from RookieRick June 10, 2021 15:57
RookieRick
RookieRick approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@RookieRick RookieRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #232

@dekim24 dekim24 merged commit a529749 into master Jun 11, 2021
@dekim24 dekim24 deleted the ekim/update-flask branch June 11, 2021 15:30
@dekim24 dekim24 linked an issue Jun 11, 2021 that may be closed by this pull request
Support for Flask v2 #232
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RookieRick RookieRick RookieRick approved these changes

Assignees

@jordannielson jordannielson

@RookieRick RookieRick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Flask v2
3 participants
@dekim24 @RookieRick @jordannielson