Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async handler support #311

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Async handler support #311

merged 1 commit into from
Apr 8, 2024

Conversation

jonls
Copy link
Contributor

@jonls jonls commented Apr 3, 2024

As far as I can tell, all that is needed is to wrap the call to the handler in current_app.ensure_sync() as described in https://flask.palletsprojects.com/en/2.3.x/async-await/#extensions

Issue for this feature request: #231

@jonls jonls requested a review from a team as a code owner April 3, 2024 01:04
@jonls jonls requested a review from gtmanfred April 3, 2024 01:04
gtmanfred
gtmanfred approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@gtmanfred gtmanfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would love to see us eventually get to a place where we can also support Quart.

@jonls jonls merged commit 6d9b178 into master Apr 8, 2024
82 checks passed
@jonls jonls deleted the jonls/async-handler branch April 8, 2024 16:43
@airstandley airstandley mentioned this pull request Apr 13, 2024
Open
@auramix auramix mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtmanfred gtmanfred gtmanfred approved these changes

Assignees

@gtmanfred gtmanfred

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonls @gtmanfred