API-425, API-416, API-426: Initial version #1
Conversation
kirkplangrid
commented
Nov 18, 2015
kirkplangrid
commented
- This version only supports .Net45. We'll create a new ticket to add other individual platforms.
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <configuration> | ||
| <appSettings> | ||
| <add key="PlanGridApiBaseUrl" value="https://plangrid-c-api-dispatcher-test.herokuapp.com" /> |
There was a problem hiding this comment.
That's intentional. Any reason it should point to prod?
There was a problem hiding this comment.
(this is for unit tests)
|
ooooo |
| </appSettings> | ||
|
|
||
| Ensure that you do not already have an `<appSettings>` node -- if you do, add |
There was a problem hiding this comment.
Our customers might appreciate the coddling.
There was a problem hiding this comment.
@robjailall yeah, agreed.
|
@marchello2000 you may want to take a look too in case we want changes to copyrights, etc. |
| <authors>kirk</authors> | ||
| <owners>kirk</owners> | ||
| <projectUrl>https://github.com/plangrid/plangrid-api-net</projectUrl> | ||
| <licenseUrl>http://www.opensource.org/licenses/mit-license.php</licenseUrl> |
There was a problem hiding this comment.
Do we need to remove the copyright headers?
There was a problem hiding this comment.
I'll let @marchello2000 chime in on how we want to handle file headers vis a vis an open-source license.
There was a problem hiding this comment.
Current plan is to go with MIT license like @kirkplangrid has it - @abhikp will double check with legal though.
|
👍 - lets wait to hear back on the copyright stuff |
|
@josephdwyer also, we want to make sure versioning in |
| // by using the '*' as shown below: | ||
| // [assembly: AssemblyVersion("1.0.*")] | ||
| [assembly: AssemblyVersion("1.0.0.0")] | ||
| [assembly: AssemblyFileVersion("1.0.0.0")] |
There was a problem hiding this comment.
Some way to version this. Either the way we do it in PlanGrid.exe (see \Build\GenerateBuildNumber.ps1) or your method you mentioned yesterday
There was a problem hiding this comment.
Yeah, I got this working already this morning, but it's part of the jenkins script, so not a part of this pull request.
|
@marchello2000 wanted to make sure you had a chance to review my last commits before merging. |
|
Thanks @kirkplangrid looks good to me! And @abhikp just confirmed, MIT license is GTG! |
|
@marchello2000 last thing, what should the file header be for each file. Is what we have right now OK? Is:
Appropriate for the MIT license? @josephdwyer pointed out that concern, and I'm curious too. |
|
(i.e. what happens if someone does a PR and we merge their code? I Am Not a Lawyer, etc.) |
|
Ah, didn't notice/understand that. My impression (from my limited exposure to this in the past life) that this is correct attribution. But... I am not a lawyer :) So... I will check on that. In the mean time it's good since we don't expect anyone to contribute. Btw, the way the repo is setup they can't just push to master, they have to PR the changes, right? I am not sure how this works |
|
@marchello2000 yeah, as a public repo, it's standard Github operating procedures. Which means that we can do what we will, but non-plangrid fold will be forced to fork and submit PRs in the usual open-source fashion. |
|
Gotcha, thanks! |
kirkplangrid
force-pushed
the
kirk/api-425-initial-version
branch
from
520d740
to
5916193
Compare
