Project Properties Updated #10
Conversation
-added address fields present in v1.8.0 of the PlanGrid API
-was necessary for DateTime
PlanGrid.Api/Project.cs
Outdated
| public string Owner { get; set; } | ||
|
|
||
| [JsonProperty("start_date")] | ||
| public DateTime? StartDate { get; set; } |
There was a problem hiding this comment.
StartDate and EndDate should be Date?s for both classes as they're ISO dates and are nullable. Check out the project object to see their format.
There was a problem hiding this comment.
Ah, good point. So they never include a time component? In that case, yeah, @JuliusAlexanderIV is right and they should use our custom Date class instead. Also, I second my thanks! :)
|
@BRyeGmoney looks good, thanks for updating this! I just have one comment. |
-time not stored in start_date and end_date properties. ISO-8601 format of YYYY-MM-DD. Using custom Date type
There was a problem hiding this comment.
Looks good! Please squash everything into one commit and then go ahead and merge it. Thanks again for updating this @BRyeGmoney
|
@JuliusAlexanderIV @kswoll no problemo. i imagine you guys are doing the squashing as part of the merge? |
|
@BRyeGmoney thanks for the PR, I just merged it into the master branch so it's now available on Nuget! |
-added address fields present in v1.8.0 of the PlanGrid API
This change is