Add support for Bearer tokens. #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlanGrid.Api/PlanGridHttpHandler.cs
Outdated
| byte[] authParamBytes = Encoding.ASCII.GetBytes(unencoded); | ||
| string encodedAuthParams = Convert.ToBase64String(authParamBytes); | ||
| return encodedAuthParams; | ||
| if (tokenType == TokenType.Basic) |
There was a problem hiding this comment.
This is fine, but a switch statement might be more idiomatic for this purpose.
| private RefitSettings settings; | ||
| private string version; | ||
| private int? maxRetries; | ||
|
|
||
| public PlanGridHttpHandler(string accessToken, RefitSettings settings, string version, int? maxRetries) | ||
| public PlanGridHttpHandler(string accessToken, RefitSettings settings, string version, int? maxRetries, TokenType tokenType = TokenType.Basic) |
There was a problem hiding this comment.
I think this will probably require some callsite changes in PlanGridApiClient:
https://github.com/plangrid/plangrid-api-net/blob/master/PlanGrid.Api/PlanGridClient.cs#L50
var api = (AutoGeneratedIPlanGridApi)RestService.For<IPlanGridApi>(
new HttpClient(new PlanGridHttpHandler(apiKey, settings, version, maxRetries))
{
BaseAddress = new Uri(url), Timeout = TimeSpan.FromSeconds(timeout)
},
settings);
i.e. you'll want to surface this new type in the Create method so clients have the opportunity to override the default scheme.
PlanGrid.Api/PlanGridHttpHandler.cs
Outdated
| @@ -42,7 +44,7 @@ public PlanGridHttpHandler(string accessToken, RefitSettings settings, string ve | |||
| request.Content = new StringContent("", Encoding.UTF8, "application/json"); | |||
| } | |||
|
|
|||
| request.Headers.Authorization = new AuthenticationHeaderValue("Basic", authenticationToken); | |||
| request.Headers.Authorization = new AuthenticationHeaderValue(this.tokenType, authenticationToken); | |||
There was a problem hiding this comment.
I think this won't compile? i.e. you probably need a .ToString() at the end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is