-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Relationship nullable #12
Make Relationship nullable #12
Conversation
I wasn't sure how to complete the CHANGELOG so that will probably need some work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! One small comment on the README.
Thanks for the change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squashing is nice :)
Might need @RookieRick to help us merge/deploy |
48787f7
to
dc5731d
Compare
I've squashed it 😄 |
Hi Guys, any ETA on a merge/release? I think my squash killed the approval as well. Cheers! |
I'm not sure who's responsible for this at PlanGrid anymore. |
Ah! Sorry for the long wait, I missed this notification. @barakalon The honest answer is that I'm not sure anyone is responsible for this at this time. Let me ask around and find out next steps. In the mean time I will try to get this merged and a new version released. |
Maybe transfer ownership to me? |
That would be the best outcome in my mind 😄 |
@rpanman-sonatype New version should now be available https://pypi.org/project/soql/1.2.0/ Thank you for the contribution, and again I'm very sorry for the long wait! |
Oh wow. Likewise, my apologies. Caught me when I was in the midst of moving (which I just finished doing AGAIN, but this time back out of RV and into a new - to us at least - house)! <3 |
Thanks and no worries about the delay, I just subclassed it locally so it didn't impact me 😄 - at least I can delete that now and make it pure soql! Also well done to @barakalon for taking on the mantle of responsibility - maintainers are had to find 🥇 |
This PR allows Relationships to be made nullable as discussed in #11.