Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Relationship nullable #12

Conversation

rpanman-sonatype
Copy link
Contributor

This PR allows Relationships to be made nullable as discussed in #11.

@rpanman-sonatype
Copy link
Contributor Author

I wasn't sure how to complete the CHANGELOG so that will probably need some work.

Copy link

@barakalon barakalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! One small comment on the README.

Thanks for the change!

README.rst Outdated Show resolved Hide resolved
Copy link

@barakalon barakalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squashing is nice :)

@barakalon
Copy link

Might need @RookieRick to help us merge/deploy

@rpanman-sonatype rpanman-sonatype force-pushed the add_nullable_handling_for_Relationship branch from 48787f7 to dc5731d Compare October 25, 2022 16:34
@rpanman-sonatype
Copy link
Contributor Author

I've squashed it 😄

@rpanman-sonatype
Copy link
Contributor Author

Hi Guys, any ETA on a merge/release? I think my squash killed the approval as well. Cheers!

@barakalon
Copy link

I'm not sure who's responsible for this at PlanGrid anymore.

@airstandley?

@airstandley
Copy link
Contributor

airstandley commented Feb 15, 2023

Ah! Sorry for the long wait, I missed this notification.

@barakalon The honest answer is that I'm not sure anyone is responsible for this at this time. Let me ask around and find out next steps.

In the mean time I will try to get this merged and a new version released.

@airstandley airstandley merged commit bbc7854 into plangrid:master Feb 15, 2023
@barakalon
Copy link

Maybe transfer ownership to me?

@airstandley
Copy link
Contributor

Maybe transfer ownership to me?

That would be the best outcome in my mind 😄

@airstandley
Copy link
Contributor

@rpanman-sonatype New version should now be available https://pypi.org/project/soql/1.2.0/

Thank you for the contribution, and again I'm very sorry for the long wait!

@RookieRick
Copy link
Contributor

Might need @RookieRick to help us merge/deploy

Oh wow. Likewise, my apologies. Caught me when I was in the midst of moving (which I just finished doing AGAIN, but this time back out of RV and into a new - to us at least - house)! <3

@rpanman-sonatype
Copy link
Contributor Author

Thanks and no worries about the delay, I just subclassed it locally so it didn't impact me 😄 - at least I can delete that now and make it pure soql!

Also well done to @barakalon for taking on the mantle of responsibility - maintainers are had to find 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants