-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markdown editor in the card description when editting #333
Add markdown editor in the card description when editting #333
Conversation
Since the card support markdown render, it'd be great if we also had markdown editor so for those who doesn't understand a lot about markdown could use this feature. With this new feature, there also a drawbacks such as no longer saving when input are onBlur since if we still using this `blur` callback, it'd be called when user trying to click at the editor toolbar such as **Bold** button.
Also i have some suggestion for the eslint and prettier settings, i think it'd be great if we add more tab spacing and print width in the prettier so you can read the code more better Here's the current configuration: {
"printWidth": 100,
"singleQuote": true,
"trailingComma": "all",
} My proposed settings: {
"printWidth": 200,
"singleQuote": true,
"trailingComma": "all",
"tabWidth": 4
} |
And if we can change eslint no-unused-vars settings to "warn" i think that would be great to speed up development, since you don't need to handle with unused vars while developing (adding/removing) features that requires a lot of variables I think it'd be better if we clean up those mess in the end before releasing into production, wdyt? Proposed eslint rules: "no-unused-vars": "warn" With this feature, any unused vars would not block front-end to rendering the component |
Hi! It's a cool addition 👍 Regarding eslint and prettier settings, I don't think it would work for me because of the 13-inch screen. We should probably think about how to set it up so that we can work locally with other settings... Regarding the |
Alright so then i'll edit up the eslint settings and also i'll remove some unused features from the markdown editor, what do you think about that? |
- Remove padding - Remove border Most of the stylings had been done within its React SimpleMDE Package
Perfect! Thank you 🙏 |
Wow, good work!! |
Thank you so much 🙏 |
Since the card support markdown render, it'd be great if we also had markdown editor so for those who doesn't understand a lot about markdown could use this feature.
With this new feature, there also a drawbacks such as no longer saving when input are onBlur since if we still using this
blur
callback, it'd be called when user trying to click at the editor toolbar such as Bold button.