Fix: Keep comment edits when textarea loses focus #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi! Thanks for this fix. I'm wondering if it would be better to save the changes instead of just prevent closing? Thought about what if I accidentally close the entire modal. |
Sure! Happy to contribute. Latest changes supports this. Changes persist on blur and modal close (by exit 'X' button and click outside of modal). |
|
Thank you! I apologize for the delay in responding. For some reason I missed this PR 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #441
This PR is a proposed fix for the linked issue by not reverting the text-state onBlur callbacks. This achieves parity with the card Add/Edit description functionality where the "Save" button remains visible with the same focus/blur actions.