Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] feat: ✨ add a link parser for tasks #694

Merged
merged 3 commits into from Apr 10, 2024

Conversation

HannesOberreiter
Copy link
Contributor

This pull request introduces a new visual render feature aimed at improving the user experience within Planka. Additionally, it includes a small CSS enhancement to refine the appearance of overflowing text in the dashboard view.

Changes Made:

Visual Render Feature:

  • Implemented a new feature that renders tasks containing links as actual link tags.
  • Utilized a XSS parser as a security measure due to the use of dangerously set innerHTML.

LinkParserExample

CSS Enhancement:

Before:

overflow not hidden

After:

overflow hidden

@meltyshev
Copy link
Member

Hi! Thanks for working on this 🙏

I think that instead of parsing links manually, we can use https://linkify.js.org/docs/linkify-react.html (or make something similar). This will also give us more options, such as ease to reuse in other places, instead of !event.target.closest('a') we can do event.stopPropagation() (since we have access to the link component and can define onClick), and also in this case dangerouslySetInnerHTML is not used. I can try to change that right in this PR, but a little later :)

@meltyshev meltyshev merged commit cc32daa into plankanban:master Apr 10, 2024
1 check passed
robertocjunior pushed a commit to robertocjunior/planka that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants