New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter cards with shortcuts to users and labels #713
Conversation
Hi! Thanks for working on this 馃檹 We really like that it's possible to add members and labels right from the text, as well as search using regular expressions. We'd like to add slight style improvements for the search input. Please note that we'll not be able to accept this PR without a signed CLA. |
Currently updating this PR to be able to filter by creator of the cards, using ! as the starting character |
amazing to see this onboarding, thank you!! |
The filter by creator is implemented. |
Thank you! I'll try to check everything today/tomorrow :) |
client/src/models/Label.js
Outdated
static findLabelsFromText(filterText, labels) { | ||
const selectLabel = filterText.toLocaleLowerCase(); | ||
const matchingLabels = labels.filter((label) => | ||
label.name.toLocaleLowerCase().startsWith(selectLabel), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Label name can be empty, and if there is such a label, an error Cannot read properties of null (reading 'toLocaleLowerCase')
will occur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix this
I have a small suggestion to not add users/labels to the filter immediately. For example if a board has user Probably adding to the filter should be done only if there is a space after the username (or maybe you have any other suggestions)? |
Well, in fact, in your case, when typing |
I think that would be a good solution. Everything else works perfectly :) |
Both are fixed |
Perfect, thanks 馃檹 |
Hello |
Sure it's possible and quite simple. I don't think that the markdown syntax will be a problem that need a workaround. |
You can check #729 PR |
Thanks for the quick response with the fix! I'll accept the PR right away. |
Hi,
I've implemented the card search functionality #53.
This feature allows users to search for :
It enhances the overall usability of the project and keep it simple with only a few click.
Changes made:
Testing:
Preview :
Thanks for reviewing! 馃檶