Add App Name to Build Notifier #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add App Name to Build Notifier
Why
Services and Music Stand share the same slack channel and it wasn't obvious which app was being built. This PR adds the app icon to the title of the build message
How
Added an
app_nameattribute to the build config and mapped it to a slack app icon emoji.Things to note
Acceptable values are
["services", "music_stand", "church_center_app", "check_ins", "headcounts", "people"].Also added the version number to the title, cause why not 馃樃
The
package-lock.jsonfile had a lot more changes than I was expecting after runningnpm install馃Screenshot