chore: use eslint and yarn workspace

.eslintignore

@@ -0,0 +1,2 @@
+node_modules
+packages/@(core|vue|react|angular)/@(src|demo)/**/*.d.ts

.eslintrc

@@ -0,0 +1,36 @@
+{
+  "extends": [
+    "eslint:recommended",
+    "plugin:@typescript-eslint/eslint-recommended",
+    "plugin:@typescript-eslint/recommended",
+    "prettier",
+    "prettier/@typescript-eslint"
+  ],
+  "parserOptions": {
+    "project": "./tsconfig.base.json"
+  },
+  "plugins": [
+    "plantain"
+  ],
+  "rules": {
+    "@typescript-eslint/explicit-function-return-type": "off",
+    "@typescript-eslint/no-use-before-define": "off",
+    "@typescript-eslint/explicit-member-accessibility": "off",
+    "@typescript-eslint/no-parameter-properties": "off",
+    "no-case-declarations": "off",
+    "no-useless-escape": "off",
+    "no-console": "off",
+    "plantain/promise-not-await": "error"
+  },
+  "env": {
+    "node": true
+  },
+  "overrides": [
+    {
+      "files": ["*.js"],
+      "rules": {
+        "@typescript-eslint/no-var-requires": "off"
+      }
+    }
+  ]
+}

clean-scripts.config.js

@@ -71,8 +71,7 @@ module.exports = {
     revStaticCommand
   ],
   lint: {
-    ts: `tslint ${tsFiles} --exclude ${excludeTsFiles}`,
-    js: `standard ${jsFiles}`,
+    ts: `eslint --ext .js,.ts ${tsFiles} ${jsFiles}`,
     less: `stylelint ${lessFiles}`,
     export: `no-unused-export ${tsFiles} ${lessFiles} --exclude ${excludeTsFiles}`,
     commit: `commitlint --from=HEAD~1`,
@@ -84,8 +83,7 @@ module.exports = {
     'karma start spec/karma.config.js'
   ],
   fix: {
-    ts: `tslint --fix ${tsFiles} --exclude ${excludeTsFiles}`,
-    js: `standard --fix ${jsFiles}`,
+    ts: `eslint --ext .js,.ts ${tsFiles} ${jsFiles} --fix`,
     less: `stylelint --fix ${lessFiles}`
   },
   watch: {

lerna.json

@@ -11,5 +11,6 @@
     }
   },
   "version": "5.6.1",
+  "useWorkspaces": true,
   "npmClient": "yarn"
 }

package.json

@@ -58,17 +58,21 @@
     "rollup-plugin-commonjs": "10.0.1",
     "rollup-plugin-node-resolve": "5.2.0",
     "rollup-plugin-uglify": "6.0.2",
-    "standard": "13.0.2",
     "stylelint": "10.1.0",
     "stylelint-config-standard": "18.3.0",
-    "tslint": "5.18.0",
-    "tslint-config-standard": "8.0.1",
-    "tslint-sonarts": "1.9.0",
+    "@typescript-eslint/eslint-plugin": "^1.9.0",
+    "@typescript-eslint/parser": "^1.9.0",
+    "eslint-config-prettier": "6.0.0",
+    "eslint-plugin-plantain": "0.1.2",
+    "eslint": "5.16.0",
     "type-coverage": "2.1.0",
     "typescript": "3.4.5",
     "watch-then-execute": "1.1.1",
     "webpack": "4.36.1",
     "webpack-cli": "3.3.6"
   },
+  "workspaces": [
+    "packages/*"
+  ],
   "dependencies": {}
 }

packages/angular/src/index.component.ts

@@ -61,7 +61,6 @@ export class Select2 implements ControlValueAccessor {
   private searchInputElement!: HTMLElement
   private resultsElement!: HTMLElement
 
-  // tslint:disable:member-ordering
   private _stateChanges = new Subject<void>()
 
   /** Whether the element is focused or not. */

packages/core/src/index.ts

@@ -1,10 +1,10 @@
-export type Select2Group = {
+export interface Select2Group {
   label: string;
   options: Select2Option[];
   classes?: string;
 }
 
-export type Select2Option = {
+export interface Select2Option {
   value: Select2Value;
   label: string;
   disabled?: boolean;
@@ -178,7 +178,6 @@ export function valueIsNotInFilteredData(filteredData: Select2Data, value: Selec
   return true
 }
 
-// tslint:disable-next-line:cognitive-complexity
 export function getPreviousOption(filteredData: Select2Data, hoveringValue: Select2Value | null | undefined) {
   let findIt = isNullOrUndefined(hoveringValue)
   for (let i = filteredData.length - 1; i >= 0; i--) {
@@ -202,7 +201,6 @@ export function getPreviousOption(filteredData: Select2Data, hoveringValue: Sele
   }
   return findIt ? hoveringValue : null
 }
-// tslint:disable-next-line:cognitive-complexity
 export function getNextOption(filteredData: Select2Data, hoveringValue: Select2Value | null | undefined) {
   let findIt = isNullOrUndefined(hoveringValue)
   for (const groupOrOption of filteredData) {
@@ -231,7 +229,7 @@ export function getNextOption(filteredData: Select2Data, hoveringValue: Select2V
   return findIt ? hoveringValue : null
 }
 
-function isNullOrUndefined(value: any) {
+function isNullOrUndefined<T>(value: T): value is (T extends null | undefined ? T : never) {
   return value === null || value === undefined
 }
 
@@ -245,7 +243,7 @@ export function getLastScrollTopIndex(
     results.scrollTop = 0
     return 0
   } else {
-    const scrollTop = getScrollUpIndex(filteredData, hoveringValue!)
+    const scrollTop = getScrollUpIndex(filteredData, hoveringValue)
     if (scrollTop - lastScrollTopIndex > 5) {
       lastScrollTopIndex += scrollTop - lastScrollTopIndex - 5
       const item = results.querySelectorAll('li').item(scrollTop)

packages/vue/demo/index.ts

@@ -1,6 +1,5 @@
 import Vue from 'vue'
 import Component from 'vue-class-component'
-// tslint:disable:no-duplicate-imports
 import '../dist/'
 import { Select2Option, Select2Data, Select2Group } from '../dist/'
 import { data1, data2, data3, data5, data12 } from 'select2-component/demo/'
@@ -149,5 +148,4 @@ class App extends Vue {
   }
 }
 
-// tslint:disable-next-line:no-unused-expression
 new App({ el: '#container' })

screenshots/index.ts

@@ -17,5 +17,5 @@ import puppeteer from 'puppeteer'
     await page.screenshot({ path: `screenshots/${type}-initial.png` })
   }
 
-  browser.close()
+  await browser.close()
 })()