fix: drag behaviour for custom vue component #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes(if relevant):
The drag events don't work with custom vue components in the current version (5.3.2), because
event.target
is no longer the<a>
, but an element inside the custom component. To fix this, I added a function to get the anchor element by going up one level in the DOM until the anchor (classtree-anchor
) is found.I also had to add a check to
ondragleave
, because the drag event is still fired on theevent.target
, butthis.dropTarget
is the anchor (returned by my other function). The function checks ifevent.target
is a child element ofthis.dropTarget
.There is one lint error left, but I don't know how to fix it. If you could help me again with that, that would be great :)
This patch should fix #7
Checks
git reset
thengit commit
)npm run build
)npm run lint
to check,npm run fix
to fix)npm run test
to check)