Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate ProgressBarWithHints into 2 separate widgets #79

Closed
blazern opened this issue Dec 27, 2021 · 9 comments · Fixed by #90
Closed

Separate ProgressBarWithHints into 2 separate widgets #79

blazern opened this issue Dec 27, 2021 · 9 comments · Fixed by #90
Assignees
Labels
1sp 1 story point enhancement New feature or request

Comments

@blazern
Copy link
Contributor

blazern commented Dec 27, 2021

Hints should be at the top:
image

Progress bar should be at the bottom:
image

Figma: https://www.figma.com/file/lHqzwSaWfsBiWNj9iyOaoh/plante-UI?node-id=2194%3A42214

Because now they're separated, they should be in 2 separate widget with similar logic. E.g. the hints widget can be named TimedHints.

We should try to reuse the GradientSpinner as a progress bar widget. To reuse it, make it so that it would accept custom colors and borderRadius in its constructor.
If it's not possible, a new widget should be created with a logic similar to GradientSpinner.

The new progress bar widget should be at the bottom of the page.
TimedHints should be just below the search bar (find Column which contains the search bar in MapPage).

New design should not be applied yet.

@blazern blazern created this issue from a note in Suggested Products chapter 3 (To do) Dec 27, 2021
@blazern blazern added 1sp 1 story point enhancement New feature or request labels Dec 27, 2021
@cyclomaticcomplexity1981 cyclomaticcomplexity1981 moved this from To do to In progress in Suggested Products chapter 3 Dec 28, 2021
@cyclomaticcomplexity1981
Copy link
Contributor

@blazern so if i understand correct the progressbar won't show the progress anymore?

@blazern
Copy link
Contributor Author

blazern commented Dec 29, 2021

@blazern so if i understand correct the progressbar won't show the progress anymore?

Why not? I think it should keep the progress logic it has right now.
It shows to the user that something is loading, the app hasn't hanged.

@cyclomaticcomplexity1981
Copy link
Contributor

@blazern no I agree we should show the progress. So if I understand correctly now, we show a incrementing progressbar, but the colors are gradient. So the closer to finished loading the darker to the end.

@blazern
Copy link
Contributor Author

blazern commented Dec 29, 2021

@blazern no I agree we should show the progress. So if I understand correctly now, we show a incrementing progressbar, but the colors are gradient. So the closer to finished loading the darker to the end.

Oh you're right, I somehow totally missed that we show specific progresses and it doesn't fit GradientSpinner...

@blazern
Copy link
Contributor Author

blazern commented Dec 29, 2021

@cyclomaticcomplexity1981, I talked to Olga - she and Sewa think we should try the hints + infinite progress bar from the design (with how GradientSpinner works).

What do you think?
Maybe hints alone will be enough to let our users know the loading hasn't hanged?

@cyclomaticcomplexity1981
Copy link
Contributor

@blazern i am still not sure what you mean, infinite, meaning it doesn't show the progress anymore? Like it used to be?

i think i liked to progress better. But we can try and see if the hints are enough.

@blazern
Copy link
Contributor Author

blazern commented Dec 29, 2021

Yes, I mean it wouldn't show progress anymore...
I personally like it with progress better too, but we're implementing someone else's vision, I think we should try to keep it intact :)

Maybe it's a good idea to split the current progress-bar-with-hints into 2 separate classes, but to use only the new hints-class, and to leave the extracted progress-bar not used for now.

And then to use GradientSpinner to display infinite progress on the map when something is loading.

This way it would be easy to roll back to an not-infinite progressbar in case we would want that.

@cyclomaticcomplexity1981
Copy link
Contributor

@blazern i am confused now, i think the design changed to show progress... So as a first implementation just show the incrementing progressbar at the bottom.

@blazern
Copy link
Contributor Author

blazern commented Dec 31, 2021

@blazern i am confused now, i think the design changed to show progress... So as a first implementation just show the incrementing progressbar at the bottom.

You're right it did change...
I'm fine with incrementing progressbar :)

Suggested Products chapter 3 automation moved this from In progress to Done Jan 5, 2022
blazern added a commit that referenced this issue Jan 5, 2022
 Separate ProgressBarWithHints into 2 separate widgets #79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1sp 1 story point enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants