Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment diagram has wrong legend #94

Closed
kirchsth opened this issue Dec 12, 2020 · 2 comments · Fixed by #107
Closed

Deployment diagram has wrong legend #94

kirchsth opened this issue Dec 12, 2020 · 2 comments · Fixed by #107
Milestone

Comments

@kirchsth
Copy link
Contributor

kirchsth commented Dec 12, 2020

Atm the deployment diagram uses the legend of container

grafik

Shouldn't we update it to soemthing like this

!procedure LAYOUT_WITH_LEGEND()
hide stereotype
legend right
|<color:$LEGEND_TITLE_COLOR>**Legend**</color> |
|<$CONTAINER_BG_COLOR> container |
|<color:#000000>⬜ node </color>|
endlegend
!endprocedure

(I don't know how the border color can be changed therefore I used an emoji)

grafik

@adrianvlupu
Copy link
Member

Hi, I don't think boundaries need to be added to the legend. If we add deployment node to it, then we should probably add system, enterprise boundaries etc. There would be no real way to differentiate between them inside the legend.

@kirchsth
Copy link
Contributor Author

kirchsth commented Dec 19, 2020

@adrianvlupu: Hi, do you remember the discussion as I started with the deployment diagram. You preferred the name "Node" and I told you it should be "Deployment_Node" (because boundary was my argument). But in the meantime I changed my mind and think your original idea with "Node" as element is better (I updated my implementation and used the name Node).

The (Deployment_)Node is an element and not (only) a logical boundary therefore I think it should be part of the legend.
"My" container diagram

kirchsth added a commit to kirchsth/C4-PlantUML that referenced this issue Jan 2, 2021
…om tags/stereotypes support; dynamic legend supports custom colors, border and shadow; dynamic legend displays (only) used elements, tags/stereotypes.

New added macros: SHOW_DYNAMIC_LEGEND(), AddTagSupport(), UpdateSkinparamsAndLegendEntry(), elements macros are extended with $tags="..."
kirchsth added a commit to kirchsth/C4-PlantUML that referenced this issue Jan 2, 2021
…om tags/stereotypes support; ... (2 - update macros docu with added $tags="...")
@Potherca Potherca added this to the v2.0.0 milestone Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants