Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#124 Remove not working, misleading and unused default values #125

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

kirchsth
Copy link
Contributor

the Rel_() definitions with the default argument $direction=""

!unquoted procedure Rel_($alias1, $alias2, $label, $direction="")
!unquoted procedure Rel_($alias1, $alias2, $label, $techn, $direction="")

are (details see #124)

  1. not working with default values (if $direction is "" an invalid PlantUML syntax is created)
  2. if a user uses Rel_() with 4 arguments then it is not clear whether the system uses the first or second definition. (after check. first defintion is used)

Therefore the default values are only missleading and not usable and should be removed.
BR Helmut

@Potherca Potherca linked an issue Feb 22, 2021 that may be closed by this pull request
@adrianvlupu
Copy link
Member

Nothing seems to break from this. I'm going to merge it

@adrianvlupu adrianvlupu reopened this Mar 13, 2021
@adrianvlupu adrianvlupu merged commit 5696166 into plantuml-stdlib:master Mar 13, 2021
@Potherca Potherca added this to the v2.1.0 milestone Apr 4, 2021
@kirchsth kirchsth deleted the feature/124 branch July 4, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

default $direction="" arguments of Rel_() call are not working
3 participants