Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#128: Some boundary skinparam have to be set a package skinparams too #131

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

kirchsth
Copy link
Contributor

@kirchsth kirchsth commented Mar 13, 2021

PlantUML realises all boundaries via packages therefore following package specific skinparams have to be set that the boundaries correspond with the defined rectangle<<boundary>> style (techn. text should be not bold and no sterotype should be displayed).

skinparam package {
    StereotypeFontSize 0
    FontStyle plain
}

current master branch without bugfix

@startuml
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Context.puml

System_Boundary(c1, "Sample System Boundary") {
   System(twitter, "Twitter")
}

System_Boundary(c2, "Sample System2 Boundary") {
}
@enduml

my local branch with bugfix

@startuml
!include https://raw.githubusercontent.com/kirchsth/C4-PlantUML/extended/C4_Container.puml

System_Boundary(c1, "Sample System Boundary") {
   System(twitter, "Twitter")
}

System_Boundary(c2, "Sample System2 Boundary") {
}
@enduml

All other styles (like color and shadow) can be set via the rectangle specific skinparams (no additional package specific definitions are required).

This PR should fix #128

… skinparams too (PlantUML uses internal packages)
@adrianvlupu adrianvlupu merged commit ea051eb into plantuml-stdlib:master Mar 13, 2021
@Potherca Potherca added this to the v2.1.0 milestone Apr 4, 2021
@kirchsth kirchsth deleted the feature/128 branch July 4, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Boundary styles have to be defined via "skinparam package<<...>>" (too)
3 participants