Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#133, #48: fix StereotypeFontSize 0 and StereotypeFontColor problem #136

Merged
merged 2 commits into from
Apr 3, 2021

Conversation

kirchsth
Copy link
Contributor

Hi,

I update the boundary skinparams, ... the 0 size should be fixed (new size 6) and the stereotypetext is drawn with the backgroundcolor (==remains invisible)

It can be tested via my extended branch

@startuml
!include https://raw.githubusercontent.com/kirchsth/C4-PlantUML/extended/C4_Container.puml

!$COLOR_A_5 = "#7f3b08"
!$COLOR_A_4 = "#b35806"
!$COLOR_A_3 = "#e08214"
!$COLOR_A_2 = "#fdb863"
!$COLOR_A_1 = "#fee0b6"
!$COLOR_NEUTRAL = "#f7f7f7"
!$COLOR_B_1 = "#d8daeb"
!$COLOR_B_2 = "#b2abd2"
!$COLOR_B_3 = "#8073ac"
!$COLOR_B_4 = "#542788"
!$COLOR_B_5 = "#2d004b"

' master doesn't have the new method names
' UpdateSkinparamsAndLegendEntry("boundary", $bgColor=$COLOR_A_5, $fontColor=$COLOR_NEUTRAL, $borderColor=$COLOR_A_1, $shadowing="true")

' my extended supports the new names
UpdateElementStyle("boundary", $bgColor=$COLOR_A_5, $fontColor=$COLOR_NEUTRAL, $borderColor=$COLOR_A_1, $shadowing="true")

System_Boundary(c1, "Sample System") {
    Container(web_app, "Web Application", "C#, ASP.NET Core 2.1 MVC", "Allows users to compare multiple Twitter timelines")
}

System_Boundary(c2, "Sample System") {
}
@enduml

BR Helmut

… StereotypeFontColor problem (2 - fix update with missing font/bg color too)
@kirchsth
Copy link
Contributor Author

fix "...(2-...)" supports following too

' UpdateElementStyle("boundary", $bgColor=$COLOR_A_5, $fontColor=$COLOR_A_3)
UpdateElementStyle("boundary", $fontColor=$COLOR_A_3)
' UpdateElementStyle("boundary", $bgColor=$COLOR_A_5)

' UpdateElementStyle("container", $bgColor=$COLOR_A_5, $fontColor=$COLOR_A_3)
' UpdateElementStyle("container", $fontColor=$COLOR_A_3)
' UpdateElementStyle("container", $bgColor=$COLOR_A_5)

@Potherca
Copy link
Member

Looks good!

@cbchenoweth
Copy link

Just pinging back for status update on this one. Looks like we need another approval from someone with "write access"? Who is that group / is there a way to ping them on this one?

@adrianvlupu adrianvlupu merged commit bd69532 into plantuml-stdlib:master Apr 3, 2021
@Potherca Potherca added this to the v2.1.0 milestone Apr 4, 2021
@kirchsth kirchsth deleted the feature/133 branch July 4, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants