Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#219 Update Readme.md (add sprite section, a diagram with BiRel() calls and unify relation to relationship) #220

Merged

Conversation

kirchsth
Copy link
Contributor

@kirchsth kirchsth commented Apr 8, 2022

  • "Sprites and other images" section is added to Readme.md with a description of all 3 sprite sources
  • Relationship section is reordered that "Relationship specific sprites ..." are part of the "Sprites and other images" section
  • Sample with BiRel() relationships is added too
  • All realtion(s) are renamed to relationship(s)

@Potherca can you please review it (you can check it via kirchsth/219_UpdateSpriteDocu

Thank you and BR Helmut

....

In following sample a person uses different systems, and a group of persons which have bidirectional relationships

@startuml
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Container.puml
HIDE_STEREOTYPE()

Person(a, "A")
Person(b, "B")
Person(c, "C")
Person(d, "D")
Person(e, "E")

BiRel_U(a, b, "talk with")
BiRel_R(a, c, "talk with")
BiRel_D(a, d, "talk with")
BiRel_L(a, e, "talk with")

Person(x, "X")
System(s1, "S1")
System(s2, "S2")
System(s3, "S3")
System(s4, "S4")

Rel_U(x, s1, "uses")
Rel_R(x, s2, "uses")
Rel_D(x, s3, "uses")
Rel_L(x, s4, "uses")
@enduml

(unidirectional) relationship versus bidirectional relationship

Layout (arrange) elements (without relationships)

.....

Sprites and other images

$sprite (images) can be defined with following PlantUML supported options:

  • included (standard library) sprites via their {SpriteName}; details see sprites
  • images via img:{File or Url}
  • OpenIconic via &{OpenIconicName}; details see openiconic

Size of the displayed images can be changed with ,scale={factor}.
Color of the displayed images can be changed with ,color={color} .

(If sprites are defined via $tags then the calculated legend is updated too)

@startuml
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Container.puml

'stdlib users.puml defines sprite "users"
!include <office/users/users.puml>


AddRelTag("plantuml", $textColor="$ARROW_COLOR", $lineColor="$ARROW_COLOR", $sprite="img:http://plantuml.com/logo3.png{scale=0.3}", $legendSprite="img:http://plantuml.com/logo3.png{scale=0.1}", $legendText="console triggered")

Person(user, "user group displayed with a sprite", $sprite="users")


Container(container, "Container with scaled and colored OpenIconic", $sprite="&folder,scale=5.0,color=gray")

System(system, "System with an image", $sprite="img:http://plantuml.com/logo3.png")

Rel(user, system, "Rel with image (via tags)", $tags="plantuml")
Rel(user, container, "Rel with OpenIconinc", $sprite="&folder")

SHOW_LEGEND()
@enduml

Sprite, image and OpenIconic

…ith BiRel() calls and unify relation to relationship)
@kirchsth kirchsth added this to the v2.5.0 milestone Apr 8, 2022
@kirchsth kirchsth linked an issue Apr 8, 2022 that may be closed by this pull request
Copy link
Member

@Potherca Potherca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the split and reorganisation. Things look a lot more readable to me.

Two thoughts I have (that could be follow-ups for later):

  1. The README is getting really long and contains lots of details. We might have to start thinking about splitting things up into separate docs).

  2. The Table of Content (ToC) might have to be updated:

README.md Show resolved Hide resolved
@kirchsth kirchsth merged commit c046340 into plantuml-stdlib:master Apr 10, 2022
@kirchsth kirchsth deleted the feature/219_UpdateSpriteDocu branch October 23, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

documentation of image (img:) support is missing
2 participants