Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lineThickness in AddRelTag (based on #218, #235) #254

Merged
merged 6 commits into from
Nov 3, 2022

Conversation

kirchsth
Copy link
Contributor

@kirchsth kirchsth commented Nov 1, 2022

based on PR #218 from @netrounds-fredrik and PR #235 from @fredde-fisk. Thank you for your preparatory work.

AddRelTag() is extended with a new $lineThickness argument, like AddRelTag("tag1", $lineThickness=3)

@startuml
' !include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Component.puml
!include https://raw.githubusercontent.com/kirchsth/C4-PlantUML/extended/C4_Component.puml

AddRelTag("tag1", $lineThickness=3)
AddRelTag("tag2", $lineColor="darkblue", $lineStyle=DottedLine(), $lineThickness=8)

Container(a, "A")
Container(b, "B")
Container(c, "C")

Rel(a, c, "normal")
Rel(a, b, "thickness 3", $tags="tag1")
Rel(b, c, "blue, dotted, thickness 8", $tags="tag2")

SHOW_LEGEND()
@enduml

It can be tested with my extended branch

BR Helmut

PS.: during the tests with TestLegend.puml I saw that colors of relationships can be combined, therefore I updated the README.md and TestLegend.puml too

  • (Obsolete, fixed in PlantUML >=v.1.2022.2)
    Colors of relationship tags cannot be automatically merged (PlantUML does not support it).

@kirchsth kirchsth added this to the v2.5.0 milestone Nov 1, 2022
README.md Outdated Show resolved Hide resolved
Copy link
Member

@Potherca Potherca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment regarding the docs, otherwise LGTM.

@kirchsth kirchsth merged commit b863451 into plantuml-stdlib:master Nov 3, 2022
@kirchsth
Copy link
Contributor Author

kirchsth commented Nov 3, 2022

thank you, readme is updated

@kirchsth kirchsth deleted the feature/lineThickness branch November 3, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants