Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotted relationships arrows #66

Conversation

fineconstant
Copy link

@fineconstant fineconstant commented Jun 10, 2020

Hello,

An option to make relationship arrows dotted would be very useful to express different types of relationships and distinguish them visually 馃槂

For now I named new elements using _Async suffix e.g. Rel_Async(...), but maybe it is better not to suggest that these new relationships are asynchronous and normal ones are synchronous... in the end it can mean something different based the context.
Other names like _Weak, _Dotted or something entirely else are possible - feel free to comment on this or suggest something 馃槃

@fineconstant fineconstant marked this pull request as ready for review June 10, 2020 19:49
@Floppy
Copy link

Floppy commented Sep 23, 2020

I like it and would definitely find it useful, but the naming would be better as _Dotted or similar, rather than adding specific semantics which aren't specified by C4.

@fineconstant
Copy link
Author

@Floppy Thanks for feedback, I'll rename it to _Dotted as I don't have any better idea 馃槃

@jikuja
Copy link

jikuja commented Oct 5, 2020

Actually, Brown's book is suggesting using dashed arrows for async communications.

As with elements, you can use different line styles and colour to add an additional level of information to your diagram. For example, perhaps synchronous interactions are illustrated using solid lines, whereas asynchronous interactions are illustrated using dashed lines.

The choice of the function name is semantics and the book has another even more important point for different arrow styles:

Once again, ensure that any styling supplements the existing information wherever possible and that the styles you use are described on the key/legend.

If multiple arrow styles are used it should be easy to add description to arrows and automatically add them into legend.

@fineconstant fineconstant reopened this Nov 29, 2020
@stale stale bot added the wontfix This will not be worked on label Jan 28, 2021
@Potherca Potherca removed the wontfix This will not be worked on label Feb 1, 2021
@stale stale bot added the stale Issue has not been active for 60 days label Apr 9, 2021
@Potherca Potherca added not-stale Stop issue from being marked stale by bot and removed stale Issue has not been active for 60 days labels Apr 10, 2021
@plantuml-stdlib plantuml-stdlib deleted a comment from stale bot Apr 11, 2021
@plantuml-stdlib plantuml-stdlib deleted a comment from stale bot Apr 11, 2021
@kirchsth
Copy link
Contributor

@fineconstant, @Potherca: #67 is already closed, can we close this issue based on #130 too?

@fineconstant
Copy link
Author

Close based on #130

@Potherca Potherca removed the not-stale Stop issue from being marked stale by bot label Apr 13, 2021
@kirchsth
Copy link
Contributor

With #160 dotted lines are supported too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants