Hostpath includes protocol and is confuses http/https when behind a proxy

[ctn]

plantuml-server/src/main/webapp/index.jsp

Line 10 in da290a1

String hostpath = request.getAttribute("hostpath").toString();

I have nginx handle SSL and by the time it gets to this service, the request protocol is HTTP. When this hostpath is used to construct URLs, they come back to the client browser as HTTP instead of HTTPS.

A solution is simply to drop hostpath and use relative URIs.

Is there any other reason to use hostpath here?

If not, I have a simple PR that will fix this. Thanks.

[arnaudroques]

If not, I have a simple PR that will fix this. Thanks.

You can go ahead, we will be glad to merge it.
Thanks!

[HeinrichAD]

Is there any other reason to use hostpath here?

hostpath does also include the context path of the URL.

plantuml-server/src/main/java/net/sourceforge/plantuml/servlet/PlantUmlServlet.java

Lines 266 to 267 in 3763ee7

	// hostpath
	return scheme + "://" + request.getServerName() + port + request.getContextPath();

So, the problem with your changes in PR #208 is, that it breaks the PlantUML Base URL path feature.

I think your problem should be solved if you add proxy_set_header X-Forwarded-Proto $scheme; inside your nginx configuration.

Maybe you will find one of the two examples helpful:

• https://github.com/plantuml/plantuml-server/tree/master/examples/nginx-simple
• https://github.com/plantuml/plantuml-server/tree/master/examples/nginx-contextpath

[ctn]

proxy_set_header X-Forwarded-Proto $scheme does indeed fix the scheme issue, and is a better solution. Thanks.