Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running on the Openshift platform #41

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

woopla
Copy link
Contributor

@woopla woopla commented Apr 25, 2017

A few changes are necessary for the best out-of-the-box experience on Docker-based application
platforms such as OpenShift:

  1. For security purposes, they run the containers as non-root. Before this change, the user was
    trying to write to the home dir, which is set to /root by default.
  2. Deploy time is limited, and the download of dependencies by Jetty at start-up time, while
    convenient for testing, causes timeouts when deploying. a WAR is now created during
    Docker image creation, and as a result starting up the container is really fast now.

In addition, it is now possible to enable debug logging for Jetty by uncommenting the
relevant line in the Dockerfile.

A few changes are necessary for the best out-of-the-box experience on Docker-based application
platforms such as OpenShift:
1. For security purposes, they run the containers as non-root. Before this change, the user was
   trying to write to the home dir, which is set to /root by default.
2. Deploy time is limited, and the download of dependencies by Jetty at start-up time, while
   convenient for testing, causes timeouts when deploying. a WAR is now created during
   Docker image creation, and as a result starting up the container is really fast now.

In addition, it is now possible to enable debug logging for Jetty by uncommenting the
relevant line in the Dockerfile.
@arnaudroques arnaudroques merged commit eaeca0a into plantuml:master Apr 26, 2017
@arnaudroques
Copy link
Contributor

I had to (temporary?) rename this Dockerfile to Dockerfile.openshift because we are currently trying to create an official docker image (see #40 )
When the official docker will be working, we'll see how to merge Dockerfiles.
Sorry about that!

@woopla
Copy link
Contributor Author

woopla commented Apr 27, 2017

Hmmm actually I'm going to try the modified Dockerfile from #40, I think it should be possible to minimally modify it to get it running on Openshift. Openshift can also pull images from Docker registries directly, so this would be helpful.

My goal is to make it Openshift-compatible, not Openshift-exclusive: the changes I'll make should not change anything for regular Docker users.

@woopla
Copy link
Contributor Author

woopla commented Apr 27, 2017

So I looked at the new Dockerfile, and the problem I have is that it expects a WAR file to be there. This won't work for regular users who want to use the Dockerfile. I would actually do the following:

  1. Rename Dockerfile to Dockerfile.travis
  2. Modify the docker build line in .travis.yml to docker build -t plantuml/plantuml-server:latest -f Dockerfile.travis . ;
  3. Rename Dockerfile.openshift to Dockerfile

This way everything should work out of the box for everybody.

My .02,

Clément

@Ducatel Ducatel mentioned this pull request Apr 28, 2017
HeinrichAD pushed a commit to HeinrichAD/plantuml-server that referenced this pull request Jul 19, 2023
HeinrichAD pushed a commit to HeinrichAD/plantuml-server that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants