Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upd/k8s #92

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Upd/k8s #92

merged 3 commits into from
Feb 9, 2024

Conversation

theavege
Copy link
Contributor

@theavege theavege commented Feb 9, 2024

improved usability

@The-Lum
Copy link
Collaborator

The-Lum commented Feb 9, 2024

Hello @theavege,

Don't forget also the remarks on:

With:

  • Could you change "global absolute github UR"L to "local stdlib" inclusion?

Regards,
Th.

Copy link
Collaborator

@The-Lum The-Lum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @theavege,

See some remarks on:

[Out off topic]
Also see to make a version in SVG sprites... (But... for a new enhancement...)

Regards,
Th.

Copy link
Collaborator

@The-Lum The-Lum Feb 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Maybe you could have left all the single files, and just made include in the "all" file, (to reduce size and redundancy) as:

k8s/OSS/all.puml:

!include <k8s/OSS/KubernetesApi>
!include <k8s/OSS/KubernetesCcm>
...
!include <k8s/OSS/KubernetesVol>

And why not push a PR on dcasati/kubernetes-PlantUML...

@theavege
Copy link
Contributor Author

theavege commented Feb 9, 2024

@The-Lum , I've done.

@arnaudroques arnaudroques merged commit d1ba7fc into plantuml:master Feb 9, 2024
@The-Lum
Copy link
Collaborator

The-Lum commented Feb 9, 2024

@theavege:

Thanks,

But the corrections about locale sdlib path are missing...:

  • Could you change "global absolute github URL" to "local stdlib" inclusion?

See remarks on:

And:

Regards,
Th.

@theavege theavege deleted the upd/k8s branch February 10, 2024 19:30
@The-Lum
Copy link
Collaborator

The-Lum commented Feb 12, 2024

@theavege:

Regards,
Th.

@The-Lum
Copy link
Collaborator

The-Lum commented Feb 13, 2024

[Just for traceability]
That is now done with:

Thanks a lot. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants