-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upd/k8s #92
Upd/k8s #92
Conversation
Hello @theavege, Don't forget also the remarks on: With:
Regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @theavege,
See some remarks on:
- Update/kubernetes #90
- and here for the
all.puml
file.
[Out off topic]
Also see to make a version in SVG sprites... (But... for a new enhancement...)
Regards,
Th.
k8s/OSS/KubernetesApi.puml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Maybe you could have left all the single files, and just made include
in the "all" file, (to reduce size and redundancy) as:
k8s/OSS/all.puml
:
!include <k8s/OSS/KubernetesApi>
!include <k8s/OSS/KubernetesCcm>
...
!include <k8s/OSS/KubernetesVol>
And why not push a PR on dcasati/kubernetes-PlantUML
...
@The-Lum , I've done. |
Thanks, But the corrections about locale sdlib path are missing...:
See remarks on: And: Regards, |
Regards, |
[Just for traceability] Thanks a lot. 👍 |
improved usability