Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception error when adding note to timing diagram #1465

Closed
jcrummy opened this issue Jun 19, 2023 · 3 comments
Closed

Exception error when adding note to timing diagram #1465

jcrummy opened this issue Jun 19, 2023 · 3 comments
Labels
enhancement New feature or request triage

Comments

@jcrummy
Copy link

jcrummy commented Jun 19, 2023

Describe the bug
A java.lang.UnsupportedOperationException is occurring when a note is added to a timing diagram.

To Reproduce
This minimal example reproduces the bug:

@startuml
binary "A" as a
@0
a is low
note bottom of a : The note
@enduml

Link to this example: http://www.plantuml.com/plantuml/uml/SoWkIImgAStDuKhAp4iigbHGSbHII2nMIEHoCE1ALCWiLiZ9B-VAooz9LKZABod9prN8JrD8LB1I2Cb8LG09SpcavgK0zGC0

Expected behavior
The diagram to be generated with the note

Screenshots
image

@The-Lum
Copy link
Collaborator

The-Lum commented Jun 19, 2023

Hi @jcrummy, and all,

Thanks for your report.

As mentioned on the doc.:

You can use the note top of and note bottom of keywords to define notes related to a single object or participant (available only for concise object).
See: https://plantuml.com/en-dark/timing-diagram#d50d8f9219a41435

[Ref. QA-6877]

Then it is now a wanted feature. 💡
Regards.

@jcrummy
Copy link
Author

jcrummy commented Jun 19, 2023

Ah, thank you @The-Lum , I missed that it was only available on the concise object. This is doing what it is supposed to do, then.

I'm ok closing this unless you want to keep this open to deal with it being a language exception and not a syntax error.

@The-Lum The-Lum added the enhancement New feature or request label Jun 19, 2023
arnaudroques added a commit that referenced this issue Jun 21, 2023
@arnaudroques
Copy link
Contributor

This should work better with last beta.

You can test it and tell us what you think about it!

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

3 participants