New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Chen Notation for ER-diagrams #1718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accidentally removed in a merge
You really did a great job! Many thanks for your contribution. Now you can think about document it on http://alphadoc.plantuml.com/doc/markdown/en/er-diagram |
The-Lum
added a commit
to The-Lum/vscode-plantuml
that referenced
this pull request
Apr 10, 2024
Add keywords: - `relationship` New PlantUML Keywords from: - plantuml/plantuml#1718
The-Lum
added a commit
to The-Lum/plantuml
that referenced
this pull request
Apr 10, 2024
According to `Chen` diagram and new PlantUML Keywords from: - plantuml#1718 Add `Chen` diagram on: - Syntax _(improve Language Descriptor (to follow plantuml/backlog#4))_ - Sub-diagram - Readme _(Similar to plantuml#1669)_ _[FYI @Benjamin-Davies]_
This was referenced Apr 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #945
Allows users to conceptually describe database models as Entity-Relational diagrams using Chen's notation. Although this notation appears to have fallen out of use, it is still taught in universities, so it would be nice if those students could use more modern tooling to draw their ER diagrams.
In addition to parsing the new file format, I've also added some new rendering classes as there was no existing way to draw diamonds with text in them or subset symbols in the middle of links.
I've added some simple
nonreg
tests to test the rendering output. I've also added some tests for the behaviour of the new commands.