New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ownership transaction predicate #290
Changes from all commits
293975c
0e9c0d7
16c09e4
6ad8b2e
7104567
bfb97b3
64cc3e9
33ed853
ecb2edf
4ca22d6
c00d377
9aa5f43
69255fe
cc0c03c
a16354e
235de63
e529014
29713f9
4a453ae
2fc0f12
d12a19a
57354bd
59067c6
b50d973
8da7a46
dfb25ff
3283ece
8c07093
532ad93
113cb44
7738efe
0df1ee8
ad60178
d994709
ebe05a1
bd65b29
2f34dca
3fa77c7
3a8b472
a55b606
dfae29b
062f238
935d199
f63c04c
3dc4442
f778b7c
c45053f
9ccddf9
43608be
0f0bb61
0817582
c9b97cc
debbccc
4c487d3
876654d
c4d61b4
d6607c1
04a571d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"extends": "solhint:default" | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
pragma solidity ^0.5.0; | ||
pragma experimental ABIEncoderV2; | ||
|
||
/* Internal Imports */ | ||
import {DataTypes as dt} from "./DataTypes.sol"; | ||
|
||
contract CommitmentChain { | ||
function verifyInclusion(dt.StateUpdate memory _stateUpdate, bytes memory _inclusionProof) public returns (bool) { | ||
// Always return true for now until we can verify inclusion proofs. | ||
return true; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
pragma solidity ^0.5.0; | ||
pragma experimental ABIEncoderV2; | ||
|
||
/** | ||
* @title DataTypes | ||
* @notice TODO | ||
*/ | ||
contract DataTypes { | ||
|
||
/*** Structs ***/ | ||
struct Range { | ||
uint256 start; | ||
uint256 end; | ||
} | ||
|
||
struct StateObject { | ||
address predicateAddress; | ||
bytes data; | ||
} | ||
|
||
struct StateUpdate { | ||
StateObject stateObject; | ||
Range range; | ||
uint256 plasmaBlockNumber; | ||
address depositAddress; | ||
} | ||
|
||
struct Checkpoint { | ||
StateUpdate stateUpdate; | ||
Range subrange; | ||
} | ||
|
||
struct Transaction { | ||
address depositAddress; | ||
bytes32 methodId; | ||
bytes parameters; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another name for this could be That said parameters is fine as well, just slightly confuses my intuitions if we were to add |
||
Range range; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we remove methodId?