State Receipt Ingestion in RollupOVM #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved rollup serialization out of core because it's not useful outside of wallet stuff - Added rollup serialization encode / decode utility functions in place of ABI classes - Changed uni and pigi token types to be numbers
…ytes32 issue for keccak output
There was a problem hiding this comment.
Took a quick look through. To me this looks good. I like that you're storing data and handling fraud proofs in the OVM itself. Hiding as much of the exit game complexity inside the OVM vibes with me.
Also, looked it over with @ben-chain and he approves as well!
ben-chain
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MerkleInclusionProofDeciderto the OVM for checking the validity of merkle proofsMetadata
Fixes
Contributing Agreement