Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State Receipt Ingestion in RollupOVM #450

Merged

Conversation

@willmeister
Copy link
Collaborator

commented Sep 18, 2019

Description

  • Adds MerkleInclusionProofDecider to the OVM for checking the validity of merkle proofs
  • Adds RollupOVM for handling provability checks and proofs

Metadata

Fixes

Contributing Agreement

willmeister added 12 commits Sep 17, 2019
- Moved rollup serialization out of core because it's not useful outside of wallet stuff
- Added rollup serialization encode / decode utility functions in place of ABI classes
- Changed uni and pigi token types to be numbers
… unit tests
…ytes32 issue for keccak output
Copy link
Contributor

left a comment

Took a quick look through. To me this looks good. I like that you're storing data and handling fraud proofs in the OVM itself. Hiding as much of the exit game complexity inside the OVM vibes with me.

Also, looked it over with @ben-chain and he approves as well!

packages/wallet/src/rollup-ovm.ts Outdated Show resolved Hide resolved
packages/wallet/src/rollup-ovm.ts Outdated Show resolved Hide resolved
willmeister added 2 commits Sep 19, 2019
Copy link
Contributor

left a comment

Overall this looks great! I left one comment that's kinda massive about the wallet structure to make it more in line with the vision of the ovm (what you mentioned at standup).

Lemme know if there are questions!

packages/example-rollup/index.ts Outdated Show resolved Hide resolved
packages/wallet/src/unipig-wallet.ts Outdated Show resolved Hide resolved
willmeister added 4 commits Sep 20, 2019
Copy link
Contributor

left a comment

Let's Get That Money, as they say 💰

@willmeister willmeister merged commit 24f4b6f into plasma-group:master Sep 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@willmeister willmeister deleted the willmeister:feat/418/TransactionReceiptIngestion branch Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.