This repository has been archived by the owner on Jun 10, 2019. It is now read-only.
Multitreaded TPS benchmarking subcommand #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍, I like it. Wonder if we can have all of the |
| cluster.fork(); | ||
| } | ||
|
|
||
| cluster.setMaxListeners(0) |
There was a problem hiding this comment.
What's the purpose of this? To avoid accidentally creating unnecessary listeners?
There was a problem hiding this comment.
We're using event listeners to send messages between workers and master processes. Node has a default max event listener limit set to 11 to avoid potential memory leaks. Setting it to 0 allows for unlimited listeners (and workers/CPUs) since the master process will use 1 event listener for each worker/CPU. A memory leak is not really possible because one would need to have a really high number of CPUs.
|
Moved to #69 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the main value proposition of Plasma is high TPS, I added a new subcommand:
plasma-chain benchmarkwhich launches a transaction spamming worker for each CPU and displays TPS rate in realtime.benchmarkbehaves similar totestSwarmbut removes the delay between txs, uses benchmark.js to collect stats, and displays it every 100ms.Also made some necessary changes to test/mock-accounts.js but the exports interface is the same, so it should not affect the rest of the codebase.