Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: add docker build. #42

Merged
merged 2 commits into from
Dec 9, 2016
Merged

Dockerfile: add docker build. #42

merged 2 commits into from
Dec 9, 2016

Conversation

mbana
Copy link
Contributor

@mbana mbana commented Dec 6, 2016

No description provided.

* add gophers.
RUN \
source $NVM_DIR/nvm.sh; \
npm install -g \
bfs-buffer@"^0.1.7" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did all of these come from the package.json? Is it possible to COPY that in and install off of it, or otherwise auto-generate this?

@bpowers
Copy link
Member

bpowers commented Dec 7, 2016

woah, this is awesome @mbana! I'll play with this tonight and hopefully merge, or get back with more comments!!

@mbana
Copy link
Contributor Author

mbana commented Dec 7, 2016

hi,
feel free to remove the rest of those npm install they're really not needed.
i am keen on getting this to run, so i'll leave the refactoring/cleanup to the end.

how does one get the mininal version of the hello-world-http running, https://github.com/plasma-umass/browsix/tree/master/examples/hello-world-http? does the below work for you?

$ cd examples/hello-world-http
$ make

@bpowers
Copy link
Member

bpowers commented Dec 9, 2016

@mbana good catch - I've fixed the makefile, and the URL for browsix-gopherjs. It needs docker 1.6 for now (tracked at bpowers/browsix-gopherjs#2 ) -- I've updated the docker file with that.

$ cd examples/hello-world-http
$ make

Now works from a shell in a container build with docker/build.sh!

@bpowers bpowers merged commit 7ac4036 into plasma-umass:master Dec 9, 2016
@mbana
Copy link
Contributor Author

mbana commented Dec 10, 2016

ta, :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants