Port code to build using GCC. #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this patch in place, and by building with gcc instead of clang, I was able to get coz working in Debian unstable. |
|
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55606 for the GCC bug report about this missing feature. |
|
I found two typos in the commit message. Otherwise it looks fine to me.
|
|
Please also add the version of the GCC you used. |
GCC 6 complains with "sorry, unimplemented: non-trivial designated initializers not supported/" for the original struct initializers. Rewrite code to clear structs and assign individual members instead. The designated initializers feature is only part of standard C, not (at least not yet) part of standard C++.
petterreinholdtsen
force-pushed
the
gcc-initializers
branch
from
857de9c
to
9c34d16
Compare
|
[Paul Menzel]
Thank you for the review. I've updated the branch.Happy hacking |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC complain with "sorry, unimplemented: non-trivial designated initializers
not supported" for the original struct initialiers. Rewrite code to
clear structs and assign individual members instead.