Add PEP 517 support (closes #503) #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling setup.py directly is [considered deprecated](https://setuptools.pypa.io/en/latest/deprecated/commands.html#running-setuptools-commands)
SnoopJ
commented
Dec 10, 2022
SnoopJ
commented
Dec 10, 2022
SnoopJ
commented
Dec 10, 2022
|
@SnoopJ I've re-targeted the PR to a branch I just opened for this (pep_517, original, right?). I'll work on it more in a few. |
Sounds good, let me know if you have any questions or requests 😁 |
Apparently unnecessary dependencies. It seems best to remove and re-add if needed. Co-authored-by: James Gerity <snoop.jedi@gmail.com>
|
I'm going on a short trip, so it seems best to postpone working on this until I'm back (in the 2nd week of January). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This changeset should be merged with care because of the changes it makes to
scalene's build workflows. At a minimum it should be tested on MacOS and Windows before merging!This PR introduces a
pyproject.tomlto bringscaleneinto the world of PEP 517/518.setuptoolsstill does most of the lifting, but most of the configuration is now declared in this more modern file. One big advantage of this change is that build-time dependencies are clearly separated from runtime dependencies, so end-users should not need to worry about installing packages likeCythonorwheelin order to build the project. I think this meansrequirements.txtcan be removed from the project, as it is no longer necessary in the GitHub workflow that depends on it, but I would appreciate maintainer insight on this.Pre-merge checklist
This checklist may be incomplete, please add to it if anything is missing.
pip install .) and build (withmake bdistandmake sdist) with a fresh 3.8.12 venv on Ubuntu 20.04.3DEV_BUILDis respected when performing a build, adding a.devNtag to the resulting package versionsmoketestspassed, sopip installlooks good. It would be a good idea to check the Makefile-driven workflow too (unfortunately, I don't have a Mac to test with)pip installthe repository on Windows 10 in a fresh Python 3.8.10 environment, but the Makefile-driven workflow should be checked too