Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factored out utility functions. #736

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Factored out utility functions. #736

merged 1 commit into from
Dec 9, 2023

Conversation

emeryberger
Copy link
Member

No description provided.

Comment on lines +4 to +12
from typing import (
Any,
Callable,
Dict,
List,
Optional,
Tuple,
cast
)

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'List' is not used.
@@ -77,6 +77,7 @@
LineNumber,
ScaleneStatistics,
)
from scalene.scalene_utility import *

Check notice

Code scanning / CodeQL

'import *' may pollute namespace Note

Import pollutes the enclosing namespace, as the imported module
scalene.scalene_utility
does not define '__all__'.
@emeryberger emeryberger merged commit bf1a8f0 into master Dec 9, 2023
10 checks passed
@emeryberger emeryberger deleted the refactoring branch December 10, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant