Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov compat? #30

Closed
jab opened this issue Oct 27, 2022 · 5 comments
Closed

Codecov compat? #30

jab opened this issue Oct 27, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@jab
Copy link

jab commented Oct 27, 2022

I checked the docs, tracker, and https://docs.codecov.com/docs/supported-report-formats docs, and still couldn’t tell if any of the supported output formats (is it currently just json?) are compatible with codecov.io, so thought I’d try asking here. Thanks!

@jaltmayerpizzorno
Copy link
Collaborator

That link doesn't work for me, but I searched for the supported formats, and it doesn't look like they support ours.
Yes, currently Slipcover only outputs text (intended for human use) and JSON (everything else).
Our JSON format is intended to be just about identical to coverage.py's...
It's not clear to me that that is supported, either, though.

I wonder if one of the formats they support is relatively close to ours...

@jaltmayerpizzorno jaltmayerpizzorno added the enhancement New feature or request label Oct 27, 2022
@guillaumeLepape
Copy link
Contributor

Hi. I tried few days ago to upload json coverage to codecov. I got the following the error: "the report is not usuable". After a deeper look into the codecov code, I found the error. Codecov is infering the coverage type from few elements in the file. For json coverage file, the code is the following : https://github.com/codecov/worker/blob/861583604119da9c607b588055e4f175a784a103/services/report/languages/pycoverage.py#L22

This show_contexts flag was the missing element, by adding it in the coverage file, codecov is able to recognize my report and display the coverage correctly. The measure context feature coverage py is a not supported slipcover feature. I'm not using this feature (I didn't know about it actually).
My proposal, for now, would be to hardcode this flag to False to be able to upload report to codecov.

@guillaumeLepape
Copy link
Contributor

I raised this pr to fix the issue, can you please review? #49

@jab
Copy link
Author

jab commented Feb 28, 2024

Since #49 was merged and released, is this issue fixed and can it be closed? If so, worth mentioning in the release notes? (codecov.com compatibility is not currently mentioned anywhere on https://github.com/plasma-umass/slipcover/releases which it looks like is where notable changes are listed.)

@jaltmayerpizzorno
Copy link
Collaborator

Since #49 was merged and released, is this issue fixed and can it be closed? If so, worth mentioning in the release notes? (codecov.com compatibility is not currently mentioned anywhere on https://github.com/plasma-umass/slipcover/releases which it looks like is where notable changes are listed.)

Yes, indeed! Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants