Hardcode show_contexts flag to False in json report #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Please write an explanation for this PR (motivation, use case, implications). Thanks. |
|
Hi. Yes sure, everything is explained in issue 30. #30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I tried few days ago to upload json coverage to codecov. I got the following the error: "the report is not usuable". After a deeper look into the codecov code, I found the error. Codecov is infering the coverage type from few elements in the file. For json coverage file, the code is the following : https://github.com/codecov/worker/blob/861583604119da9c607b588055e4f175a784a103/services/report/languages/pycoverage.py#L22
This show_contexts flag was the missing element, by adding it in the coverage file, codecov is able to recognize my report and display the coverage correctly. The measure context feature coverage py is a not supported slipcover feature. I'm not using this feature (I didn't know about it actually).
My proposal, for now, would be to hardcode this flag to False to be able to upload report to codecov.