Remove lambda functions #1013
Remove lambda functions #1013
Conversation
| try: | ||
| self._pars = collections.defaultdict(lambda: None) | ||
| self._pars = collections.defaultdict(return_none) |
There was a problem hiding this comment.
One of the things I read suggested that defaultdict objects cannot be pickled, so we might need to venture away from them. Out of scope for this PR, though.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1013 +/- ##
==========================================
+ Coverage 96.62% 96.67% +0.04%
==========================================
Files 64 64
Lines 6249 6278 +29
==========================================
+ Hits 6038 6069 +31
+ Misses 211 209 -2 ☔ View full report in Codecov by Sentry. |
docs/development/code_guide.rst
Outdated
| * Avoid using `lambda`. Anonymous functions created with `lambda` | ||
| cannot be pickled, and `lambda` notation may be unfamiliar to |
There was a problem hiding this comment.
That lambdas cannot be pickled is of course true; but as far as I know, and "Is there an easy way to pickle a python function (or otherwise serialize its code)?" on Stack seems to confirm, Python functions just can't be pickled at all, lambda or no lambda. "How to pickle a python function with its dependencies?" seems to show you can do it using marshal or cloudpickle packages, but that's not exactly the same thing - I don't think scipy multiprocessing will handle that, for example.
| @@ -162,8 +166,11 @@ def __init__( | |||
| ) | |||
| set_abundances = False | |||
|
|
|||
| def return_none(): | |||
| return None | |||
There was a problem hiding this comment.
Doesn't seem like that one's actually used - see codecov warning!
There was a problem hiding this comment.
Oh, cool — that means we can use a regular dict instead of a defaultdict when storing the parameters for IonizationStateCollection.
|
I revised the statement about avoiding the use of |
|
Boom! :) |
namurphy
added
plasmapy.particles
This pull request removes some
lambdaexpressions fromplasmapy.particlesandplasmapy.utilsbecauselambdaexpressions cannot be pickled. This partially address #1011. However, more would need to be done in order to pickleParticleinstances. I left thelambdaexpressions in Langmuir stuff to avoid conflicts with #889.I propose a new tongue twister: