Enable particle_stepper to run under CI #668
Conversation
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
==========================================
+ Coverage 94.95% 94.95% +<.01%
==========================================
Files 54 55 +1
Lines 4656 4657 +1
==========================================
+ Hits 4421 4422 +1
Misses 235 235
Continue to review full report at Codecov.
|
|
|
||
| species = Species(plasma, 'p', 1, 1, 1e-10 * u.s, 10000) | ||
| particle = ParticleTracker(plasma, 'p', 1, 1, 1e-4 * u.s, 40) |
There was a problem hiding this comment.
The naming here may be a bit confusing, given plasmapy.atomic.Particle. Perhaps rename this as particle_trajectory or tracked_particle or something like that?
| @@ -32,39 +33,38 @@ | |||
|
|
|||
| ############################################################ | |||
| # Initialize the particle. We'll take one proton `p` with a timestep of | |||
| # $10^{-10}s$ and run it for 10000 iterations. | |||
| # $10^{-4}s$ and run it for 40 iterations. | |||
There was a problem hiding this comment.
I was looking at the giles preview of this example, and it appears that the trajectory is more or less a straight line, with some bumpiness in the z coordinate. It'd be good to choose the timestep to be exactly one gyroorbit.
|
Hello @StanczakDominik! Thanks for updating your pull request. Congratulations! There are no PEP8 issues in this pull request. 😸 Comment last updated at 2019-09-03 18:08:56 UTC |
|
This should look better now! |
|
I went back to |
namurphy
added
the
plasmapy.simulation
As pointed out by @diego7319, this example wasn't running in CI and wasn't being actively tested. I simplified it a bit to run faster along the way.