Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopper / Dropper support #26

Open
ikafly144 opened this issue Sep 17, 2023 · 6 comments
Open

Hopper / Dropper support #26

ikafly144 opened this issue Sep 17, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@ikafly144
Copy link

At this time, playing records using a hopper or dropper and retrieving records using a hopper are not working properly.

@ProjectHSI
Copy link

ProjectHSI commented Nov 23, 2023

Can confirm this happens. Particles come from the Jukebox but there is no confirmation of sound (Loading action bar text / Title action bar text (e.g. the name of the record)) and no sound is ever played.

I think this is due to JukeboxEventListener's onHopperInsertToJukebox event not being sufficient enough (I.E. not firing or something has gone wrong in it's coding). I don't believe anything on my server is cancelling the event.

One possible solution (to the event not firing in the first place, if that indeed is the problem) is to use org.bukkit.event.inventory.InventoryMoveItemEvent, while sub-optimal as we would need to add more checks, it's possible it could work.

(P.S. I'm not a maintainer of this repository, sorry if the wording makes it sound like it.)

@MagmaBro123
Copy link

Dead project, won't happen.

@Danrejk
Copy link

Danrejk commented Mar 7, 2024

Please! This is the single best thing about plasmo voice!

@ProjectHSI
Copy link

@MagmaBro123 I think the devs might not have time to fix the problems here, that or they forgot the issues tab exists. The project is still getting updated. (You can see via the commit messages.)

@Apehum
Copy link
Member

Apehum commented Mar 8, 2024

Sorry for the really late response. Hoppers and droppers should be supported in the prerelease.

Tested with the latest version of mc 1.20.4, and everything is working fine: https://youtu.be/04FMQC0EBT4

@Apehum Apehum added the enhancement New feature or request label Mar 8, 2024
@Apehum Apehum self-assigned this Mar 8, 2024
@ProjectHSI
Copy link

Sorry for the really late response.

It's OK. Some of my issues never get resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants