Fix tikz functional test #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling 'plastex' as a subprocess relies on it being installed and so prevents in-place testing. There is also a chance of accidentally switching interpreters when going via the commandline, so permitting the test harness to set this is important.
The success of the call to 'plastex' needs to be checked to catch test failures as early as possible.
tikz testing requires various packages to be installed
|
I don't really understand what you are achieving here. How do you test that the LaTeX packages you install did anything? |
|
The test fails without those packages being installed. From https://travis-ci.org/llimeht/plastex/jobs/624911446 and then Note that in the second of the three commits, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current functional test of the tikz handler needs a few fixups:
plastexran correctly