-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When injecting a falsey export, it shouldn't fall back to real module #15
Comments
@plasticine would you be open to a PR for this? I'm thinking of changing this line: Line 55 in 14d573a
to something like:
|
@plasticine I could really use this, but it was released as part of 3.x which is blocked due to #18. How can we help? Do you need a PR or something? |
@plasticine this is broken again in 3.x. The output in 3.x looks like:
So even though |
@Aaronius Hrm—yeah looks like we might’ve regressed this in the re-write to using Babel to parse modules, which happened in 3.x. Could I get you to raise a new issue and I’ll try and tackle it soon. |
Sure! If I get a moment I might try tackling it myself. |
@Aaronius That would be amazing 💖 |
In one of my tests, I wish to inject an falsey export. That is, I want to see what module A does when it requires module B and module B exports
undefined
,null
, orfalse
. Unfortunately, inject-loader outputs something like this:Given that the injection is falsey, it doesn't use my injection and instead uses the real module which makes my test useless.
The text was updated successfully, but these errors were encountered: