-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loader didn't return a function error [3.0.0-beta1] #18
Comments
@Aaronius thanks will have a look 👍🏼 |
function inject(source) {
this.cacheable && this.cacheable();
return 'module.exports = ' + createInjectorFunction(this, source);
}
// Object.defineProperty(exports, "__esModule", {
// value: true
// });
// exports.default = inject;
module.exports = inject; a bit of hit & miss as I don't understand webpack loader system that well but this fixed it for me |
hi @plasticine, do you have plan to fix this bug? |
@lvthanh101 Yep, just haven’t had time. Hopefully soon. |
hey man, I guess you made a mistake on return value. like @oviava said
the return value should be a module, it should export some thing. so #19 got everything broken. |
https://github.com/plasticine/inject-loader/blob/master/lib/index.js#L107 here's the problem |
Please check out |
When I try to upgrade from 2.x to 3.0.0-beta1 I start getting the following errors:
I'm guessing it has to do with the es6 modules in 3.x or something.
The text was updated successfully, but these errors were encountered: