Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: preserve config.rb order of after_build callbacks #11

Closed
wants to merge 9 commits into from

Conversation

ewlarson
Copy link

Remove unnecessary after_configuration block, to preserve config.rb order of after_build callbacks.

@ewlarson
Copy link
Author

middleman/middleman-smusher#5

Another example of a middleman extension separating after_configuration from after_build to preserve the config.rb activate order of after_build tasks.

@ewlarson
Copy link
Author

ewlarson commented Mar 3, 2014

@plasticine What gives? Isn't the proof I referenced above enough to convince you to separate the callbacks?

@plasticine plasticine added this to the 0.2.0 milestone Mar 3, 2014
@plasticine
Copy link
Owner

What gives? Isn't the proof I referenced above enough to convince you to separate the callbacks?

Uhh...it probably is, sure. I’ve not been using Middleman for a while, so investigating and understanding this has not been a high priority tbh. That said I have some other things that I’m planning to roll into 0.2.0 and this is on that list.

@dikaio
Copy link

dikaio commented Apr 9, 2014

Would love to see this get merged too or 0.2.0 to get pushed out. Thanks for the awesome gem @plasticine and thanks for working on this @ewlarson.

@plasticine plasticine closed this Jan 5, 2015
@plasticine
Copy link
Owner

This should all be resolved in 0.2.0 💃

@dikaio
Copy link

dikaio commented Jan 5, 2015

+1!!!

@adampage
Copy link

adampage commented Jan 6, 2015

Sweet. Thanks for the update @plasticine and @ewlarson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants