-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: preserve config.rb order of after_build callbacks #11
Conversation
Another example of a middleman extension separating after_configuration from after_build to preserve the config.rb activate order of after_build tasks. |
@plasticine What gives? Isn't the proof I referenced above enough to convince you to separate the callbacks? |
Uhh...it probably is, sure. I’ve not been using Middleman for a while, so investigating and understanding this has not been a high priority tbh. That said I have some other things that I’m planning to roll into |
Would love to see this get merged too or 0.2.0 to get pushed out. Thanks for the awesome gem @plasticine and thanks for working on this @ewlarson. |
…geoptim Conflicts: middleman-imageoptim.gemspec
This should all be resolved in |
+1!!! |
Sweet. Thanks for the update @plasticine and @ewlarson! |
Remove unnecessary after_configuration block, to preserve config.rb order of after_build callbacks.