Skip to content

Commit

Permalink
Move to SHA256
Browse files Browse the repository at this point in the history
  • Loading branch information
José Valim committed Aug 6, 2013
1 parent 354e502 commit d56641f
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 12 deletions.
15 changes: 8 additions & 7 deletions lib/devise/rails.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,19 @@ class Engine < ::Rails::Engine
end

initializer "devise.secret_key" do
if secret_key = Devise.secret_key
Devise.token_generator = Devise::TokenGenerator.new(
Devise::CachingKeyGenerator.new(Devise::KeyGenerator.new(secret_key))
)
else
raise <<-ERROR
Devise.token_generator ||=
if secret_key = Devise.secret_key
Devise::TokenGenerator.new(
Devise::CachingKeyGenerator.new(Devise::KeyGenerator.new(secret_key))
)
else
raise <<-ERROR
Devise.secret_key was not set. Please add the following to your Devise initializer:
config.secret_key = '#{SecureRandom.hex(64)}'
ERROR
end
end
end

initializer "devise.fix_routes_proxy_missing_respond_to_bug" do
Expand Down
11 changes: 6 additions & 5 deletions lib/devise/token_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,28 +5,29 @@

module Devise
class TokenGenerator
def initialize(key_generator)
def initialize(key_generator, digest="SHA256")
@key_generator = key_generator
@digest = digest
end

def digest(klass, column, value)
value.present? && OpenSSL::HMAC.hexdigest("SHA1", key_for(column), value.to_s)
value.present? && OpenSSL::HMAC.hexdigest(@digest, key_for(column), value.to_s)

This comment has been minimized.

Copy link
@thomashs-zz

thomashs-zz Sep 2, 2019

@josevalim why is klass a parameter in this def?

end

def generate(klass, column)
key = key_for(column)

loop do
raw = Devise.friendly_token
enc = OpenSSL::HMAC.hexdigest("SHA1", key, raw)
enc = OpenSSL::HMAC.hexdigest(@digest, key, raw)
break [raw, enc] unless klass.to_adapter.find_first({ column => enc })
end
end

private

def key_for(column)
@key_generator.generate_key(column.to_s)
@key_generator.generate_key("Devise #{column}")
end
end

Expand Down

0 comments on commit d56641f

Please sign in to comment.