Avoid duplication on param filter #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…confirmation flash message.
Conflicts: app/controllers/devise/registrations_controller.rb test/integration/registerable_test.rb
| conditions | ||
| end | ||
|
|
||
| def apply_filter_method_to_condition_keys(conditions, method, condition_keys) |
There was a problem hiding this comment.
I prefer to not mutate the hash inside this method. We should return a new hash and merge then in the filter method
There was a problem hiding this comment.
Fully agree. Thanks!
josevalim
pushed a commit
that referenced
this pull request
May 7, 2013
Avoid duplication on param filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little tested refactor to avoid duplication.