Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations to view #3684

Closed
wants to merge 2 commits into from
Closed

Add translations to view #3684

wants to merge 2 commits into from

Conversation

GauthierPLM
Copy link

Hi,

I added translations to view to avoid having to edit them.

I replaced all double quoted strings when unnecessary by simple quoted strings to follow Ruby Style Guide.

@rafaelfranca
Copy link
Collaborator

Thank you so much for the work on this pull request but we'll not accept this change.

See #2058 #1642 #1983 #1989 and many others similar issues/pull requests for the reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants