Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary key type in migration template #4426

Merged

Conversation

filip373
Copy link

@filip373 filip373 commented Feb 10, 2017

Adds primary key type to migration creating template in Rails 5. It uses the configuration set in Rails generator as below:

config.generators do |g|
  g.orm :active_record, primary_key_type: :uuid
end

Resolves #4413

@filip373 filip373 force-pushed the primary-key-in-migration-template branch from b0d6962 to e0354e6 Compare February 10, 2017 14:20
@filip373 filip373 changed the title Primary key in migration template Primary key type in migration template Feb 10, 2017
@tegon
Copy link
Member

tegon commented Dec 7, 2017

Hello, @filip373, thanks for your contribution.
Your code looks good to me, could you please do a rebase with master to see if the build passes?

@filip373 filip373 force-pushed the primary-key-in-migration-template branch from c2c816e to b6da393 Compare December 9, 2017 16:21
@filip373
Copy link
Author

filip373 commented Dec 9, 2017

Hi @tegon, thanks for your response.
I've rebased the code and applied a small patch so the build passes.

@tegon tegon merged commit b01ae71 into heartcombo:master Dec 23, 2017
@tegon
Copy link
Member

tegon commented Dec 23, 2017

Thanks, @filip373!

@filip373 filip373 deleted the primary-key-in-migration-template branch February 13, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants