Rails 4 support #36
Merged
Rails 4 support #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use correct require for this newer version.
…t and Rails 3 don't care.
| @@ -0,0 +1,7 @@ | |||
| language: ruby | |||
| rvm: | |||
| - 1.9.3 | |||
There was a problem hiding this comment.
Is good to add 1.8.7 in the build matrix only to 3.2.x
There was a problem hiding this comment.
Add 1.8.7 to rvm and adding this should do it:
matrix:
exclude:
- rvm: 1.8.7
gemfile: Gemfile
|
Thank you so much |
| matrix: | ||
| exclude: | ||
| - rvm: 1.8.7 | ||
| gemfile: gemfiles/Gemfile.rails-3.2.x |
There was a problem hiding this comment.
Hey guys, I did a mistake here. It should be
matrix:
exclude:
- rvm: 1.8.7
gemfile: GemfileThere was a problem hiding this comment.
Ah, nevermind. It has beed fixed already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
On the way to make InheritedResources and its dependencies Rails 4 compatible, please review this pull request.
In this pull request I was trying to take into account all the comments I got in heartcombo/responders#60
Please let me know if you have any comments, suggestions, etc.
Thank you.